Fix: Fetch ConfigMaps and Secrets once per GrafanaContactPoint reconciliation
#1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: fetch ConfigMaps and Secrets once per reconcile
Baarsgaard
force-pushed
the
reduce_api_reads_before_cache_tuning
branch
from
3de1f6a to
cefc2a1
Compare
Baarsgaard
requested review from
NissesSenap,
weisdd,
ishanjainn,
theSuess,
hubeadmin and
pb82
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to maintain the functionality of
valuesFromon various CRDs, we're planning to disable caching entirely forConfigMapsandSecretsin #1818Referencing the ContactPoint Reconcile function during implementation of #1826 I noticed that
buildSettings, which fetched referencedConfigMapsandSecretswas called once per matchedGrafanainstance.Which is not an issue when they are cached, but will cause unnecessary requests to the api-server afterwards.
While fixing this, I also added the
InvalidSpeccondition whenbuildContactPointSettingsreturns an error.